-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/85 wrong type used in chapters definition #122
Merged
miroslavpojer
merged 9 commits into
master
from
bugfix/85-Wrong-type-used-in-chapters-definition
Dec 12, 2024
Merged
Bugfix/85 wrong type used in chapters definition #122
miroslavpojer
merged 9 commits into
master
from
bugfix/85-Wrong-type-used-in-chapters-definition
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented yaml array type as input ofr chapters.
- Change format of input from json string to yaml array. - Several small improvement required by pylint.
MobiTikula
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please react and make correction to this PR.
…nition # Conflicts: # .github/workflows/release_draft.yml # examples/release_draft.yml # release_notes_generator/action_inputs.py # release_notes_generator/utils/pull_reuqest_utils.py # requirements.txt # tests/test_action_inputs.py
MobiTikula
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please react to my review comments.
MobiTikula
reviewed
Dec 12, 2024
MobiTikula
approved these changes
Dec 12, 2024
miroslavpojer
deleted the
bugfix/85-Wrong-type-used-in-chapters-definition
branch
December 12, 2024 12:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Closes #85