Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/85 wrong type used in chapters definition #122

Merged

Conversation

miroslavpojer
Copy link
Collaborator

Release Notes:

  • Change the format of input from JSON string to YAML array.
  • New dependency on PyYAML package.
  • Several minor improvements required by Pylint.

Closes #85

- Implemented yaml array type as input ofr chapters.
- Change format of input from json string to yaml array.
- Several small improvement required by pylint.
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please react and make correction to this PR.

.github/workflows/release_draft.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
examples/release_draft.yml Show resolved Hide resolved
release_notes_generator/action_inputs.py Show resolved Hide resolved
…nition

# Conflicts:
#	.github/workflows/release_draft.yml
#	examples/release_draft.yml
#	release_notes_generator/action_inputs.py
#	release_notes_generator/utils/pull_reuqest_utils.py
#	requirements.txt
#	tests/test_action_inputs.py
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please react to my review comments.

release_notes_generator/action_inputs.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@MobiTikula MobiTikula self-requested a review December 12, 2024 10:59
action.yml Outdated Show resolved Hide resolved
release_notes_generator/action_inputs.py Show resolved Hide resolved
@MobiTikula MobiTikula self-requested a review December 12, 2024 11:16
@miroslavpojer miroslavpojer merged commit d1b2cdb into master Dec 12, 2024
4 checks passed
@miroslavpojer miroslavpojer deleted the bugfix/85-Wrong-type-used-in-chapters-definition branch December 12, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type used in chapters definition
2 participants